馃悰 SuperConWorkChain: should_run_final should return boolean value - #70
Open
ymzhang0 wants to merge 1 commit into
Open
馃悰 SuperConWorkChain: should_run_final should return boolean value#70ymzhang0 wants to merge 1 commit into
should_run_final should return boolean value#70ymzhang0 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I separate the inspection of convergence loop into an independent
inspect_interpolationstep to make sureshould_run_finalshould return boolean value.If not so, the
should_run_finalcan return ExitCode that is captured by if_ predicate even if all the convergence calculations fail.